Ngone51 commented on PR #53814: URL: https://github.com/apache/spark/pull/53814#issuecomment-3777932765
My concern is that, althought both `ExecutionException` and `InterruptedException` are non-fatal, is there a case we consider the execption is non-fatal becasue of `ExecutionException` rather than `InterruptedException` (which I think is an unexpected behaviour)? Checking the `Executor.isFatalError()`, it looks like when depthToCheck < 2, `isFatalError` returns false because of `depthToCheck <= 0`. And only when `depthToCheck >= 2`, the cause (i.e., `InterruptedException`) is really verified by `isFatalError()` as non-fatal. I think this is what you meant(?). And my concern is invalid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
