garlandz-db commented on code in PR #53916:
URL: https://github.com/apache/spark/pull/53916#discussion_r2716811303


##########
common/utils/src/main/java/org/apache/spark/SparkThrowable.java:
##########
@@ -52,10 +52,8 @@ public interface SparkThrowable {
   // Portable error identifier across SQL engines
   // If null, error class or SQLSTATE is not set
   /**
-   * @deprecated Override this method to provide a custom SQL state.
-   *             The default implementation uses the error class reader.
+   * == Please override this method and use a provided SQL state property 
instead ==

Review Comment:
   this is equivalent to making sqlState optional because if the sqlState 
property is None, the fallback will read from the json file. i can reword the 
comment if thats sufficient



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to