garlandz-db commented on code in PR #53916:
URL: https://github.com/apache/spark/pull/53916#discussion_r2717547611
##########
common/utils/src/main/java/org/apache/spark/SparkThrowable.java:
##########
@@ -52,10 +52,8 @@ public interface SparkThrowable {
// Portable error identifier across SQL engines
// If null, error class or SQLSTATE is not set
/**
- * @deprecated Override this method to provide a custom SQL state.
- * The default implementation uses the error class reader.
+ * == Please override this method and use a provided SQL state property
instead ==
Review Comment:
im not sure i follow. the original problem on why we are even intorducing
this, is because the client side exceptions need to store sql state. this
ensures we can get proper lineage of the sql state. so if a user calls
`getSqlState` on a client side exception, it should try to retrieve the local
property first (ideally it always will but its too late for previous spark
versions so we need to fallback to reading from the error class json file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
