zhengruifeng commented on code in PR #53992:
URL: https://github.com/apache/spark/pull/53992#discussion_r2734615471
##########
python/pyspark/sql/pandas/serializers.py:
##########
@@ -409,21 +414,21 @@ def arrow_to_pandas(
ndarray_as_list=ndarray_as_list,
)
- def _create_array(self, series, arrow_type, spark_type=None,
arrow_cast=False):
+ def _create_array(self, series, spark_type, *, arrow_cast=False,
prefers_large_types=False):
"""
- Create an Arrow Array from the given pandas.Series and optional type.
+ Create an Arrow Array from the given pandas.Series and Spark type.
Parameters
----------
series : pandas.Series
A single series
- arrow_type : pyarrow.DataType, optional
- If None, pyarrow's inferred type will be used
spark_type : DataType, optional
- If None, spark type converted from arrow_type will be used
- arrow_cast: bool, optional
+ The Spark type to use. If None, pyarrow's inferred type will be
used.
Review Comment:
wait, the spark type here is the return type?
I think it should never be None?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
