zhengruifeng commented on code in PR #53992:
URL: https://github.com/apache/spark/pull/53992#discussion_r2734626184
##########
python/pyspark/sql/pandas/serializers.py:
##########
@@ -617,66 +621,80 @@ def arrow_to_pandas(self, arrow_column, idx):
def _create_struct_array(
self,
df: "pd.DataFrame",
- arrow_struct_type: "pa.StructType",
- spark_type: Optional[StructType] = None,
+ spark_type: StructType,
Review Comment:
shall we rename return type `spark_type` to `return_type` to be consistent
with `worker.py`?
We have `input_type` in this file for input schema, `spark_type` is kind of
confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
