viirya commented on code in PR #53859:
URL: https://github.com/apache/spark/pull/53859#discussion_r2738250760
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala:
##########
@@ -695,6 +701,21 @@ case class EnsureRequirements(
child, values, joinKeyPositions, reducers, applyPartialClustering,
replicatePartitions))
}
+ private def disableKeyGroupingIfNotNeeded(child: SparkPlan) = {
Review Comment:
More detailed comments on this method would be good, e.g., the conditions
under which grouping can be safely disabled, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
