peter-toth commented on code in PR #53859:
URL: https://github.com/apache/spark/pull/53859#discussion_r2738424594


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala:
##########
@@ -695,6 +701,21 @@ case class EnsureRequirements(
         child, values, joinKeyPositions, reducers, applyPartialClustering, 
replicatePartitions))
   }
 
+  private def disableKeyGroupingIfNotNeeded(child: SparkPlan) = {
+    if (canApplyPartialClusteredDistribution(child)) {
+      populateNoGroupingPartitionInfo(child)
+    } else {
+      child
+    }
+  }
+
+  private def populateNoGroupingPartitionInfo(plan: SparkPlan): SparkPlan = 
plan match {

Review Comment:
   Yes, I can change this to use `transform()` APIs.
   Wanted to make it similar to the other 2 `populate...()` methods. Shall I 
change those as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to