szehon-ho opened a new pull request, #54126: URL: https://github.com/apache/spark/pull/54126
### What changes were proposed in this pull request? This change passes a DSV2 Expression (from an analyzed generated column Expression) to the DSV2 API. It also cleans up the code. Previously, the generation expression is analyzed by an independent analyzer. Now, it is inline (similar to how constraint expressions are analyzed). This makes it easier to run optimizer rules to constant fold the expression, before they are passed into DSV2. ### Why are the changes needed? Code cleanup and to make DSV2 data source able to work with DSV2 Expression API for generated columns ### Does this PR introduce _any_ user-facing change? Some error messages may change, but overall should be the same. ### How was this patch tested? Added new tests in DataSourceV2DataFrameSuite, and changed error case expectations in existing tests. ### Was this patch authored or co-authored using generative AI tooling? Some claude 4.5 opus, but hand tuned -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
