szehon-ho commented on code in PR #54126: URL: https://github.com/apache/spark/pull/54126#discussion_r2771526777
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/GenerationExpression.java: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.catalog; + +import java.util.Map; +import java.util.Objects; +import javax.annotation.Nullable; + +import org.apache.spark.SparkIllegalArgumentException; +import org.apache.spark.annotation.Evolving; +import org.apache.spark.sql.connector.expressions.Expression; + +/** + * A class that represents generation expressions for computed/generated columns. + * <p> + * Connectors can define generation expressions using either a SQL string (Spark SQL dialect) or an Review Comment: hm, good point, this comment is a bit confusing. By Spark SQL dialect, I meant anything today supported by Spark. I can remove this. This is to make sure existing connector still work, as currently the Column has generated columns as Strings. We are adding another DSV2 mode for the future , which represents generated column optionally as an DSV2 API connector.expressions.Expression, which is only supported in ANSI mode (and not in non-ANSI mode). Spark should support both modes, though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
