gaogaotiantian commented on code in PR #54085: URL: https://github.com/apache/spark/pull/54085#discussion_r2767449282
########## python/pyspark/sql/streaming/datasource.py: ########## @@ -0,0 +1,234 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from abc import ABC, abstractmethod + + +class ReadLimit(ABC): Review Comment: I think this `ABC` is over-designed, especially considering that we do not even support custom `ReadLimit` class at this point. `type_name` does not really do anything besides returning an identifier for this class. It's only used internally I think you can directly use `self.__class__.__name__`. `cls.load(param) -> cls` is not a super common pattern in python or pyspark. This is just `__init__` I think. You just need the subclass to have an `__init__` function that takes a parameter. Save that `parameter` and use it in `dump` would be fine. Bottom line is, you just need a serializable enum that take some argument. I think you can totally do it with just dataclass. ```python from dataclasses import dataclass class ReadLimit: ... @dataclass class ReadAllAvailable(ReadLimit): type: str = "ReadAllAvailable" @dataclass class ReadMinRows(ReadLimit): type: str = "ReadMinRows" min_rows: int ``` You can do `dataclasses.asdict(obj)` to dump it and `registry[type](**params)` to create the class. What's the concerns to use this simple pattern? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
