gaogaotiantian commented on code in PR #54085: URL: https://github.com/apache/spark/pull/54085#discussion_r2767534350
########## python/pyspark/sql/streaming/datasource.py: ########## @@ -0,0 +1,234 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from abc import ABC, abstractmethod + + +class ReadLimit(ABC): Review Comment: Yeah there could still be custom `RateLimit` in the future. The difference is that the user only needs to define a dataclass like ```python @dataclass class MyOwnRateLimiter(RateLimit): name = "MyOwnRateLimiter" param1: int param2: str ``` And that's it - they don't need to do anything else. I changed `type` to `name` here because I think that's probably a bit more intuitive. Also `type` is a global variable so even though it's okay to use it here, I try to avoid it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
