zhengruifeng commented on PR #54156: URL: https://github.com/apache/spark/pull/54156#issuecomment-3857386133
> I think local benchmark to test against a certain commit locally is nice. GHA is not great with benchmark because it's just too volatile. The numbers won't have much meanings across timeline (unless it's super obvious). @gaogaotiantian I am thinking about adding relative metrics instead of absolute values。 For example, I tried multiple method of arrow->pandas conversion https://github.com/apache/spark/blob/5de75d8ef5b28dd922b63f9086ed78fdde23d0aa/python/pyspark/sql/conversion.py#L1361-L1373 suppose we have 2 functions, A and B, does it make sense to benchmark performance A vs B？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
