Yicong-Huang commented on code in PR #54156:
URL: https://github.com/apache/spark/pull/54156#discussion_r2772848024
##########
python/benchmarks/asv.conf.json:
##########
@@ -0,0 +1,30 @@
+{
+ "version": 1,
+ "project": "pyspark",
+ "project_url": "https://spark.apache.org/";,
+ "repo": "../..",
+ "branches": ["master"],
+ "dvcs": "git",
+ "environment_type": "virtualenv",
+ "show_commit_url": "https://github.com/apache/spark/commit/";,
+ "benchmark_dir": ".",
+ "env_dir": ".asv/env",
+ "results_dir": ".asv/results",
+ "html_dir": ".asv/html",
+ "build_command": [
+ "python -m pip wheel --no-deps -w {build_cache_dir}
{conf_dir}/../packaging/classic"
+ ],
+ "install_command": [
+ "python -m pip install --find-links {build_cache_dir} pyspark"
+ ],
+ "uninstall_command": [
+ "python -m pip uninstall -y pyspark"
+ ],
+ "matrix": {
+ "req": {
+ "pyarrow": [""],
+ "pandas": [""],
+ "numpy": [""]
+ }
Review Comment:
shall we ping versions of libraries?
##########
python/benchmarks/asv.conf.json:
##########
@@ -0,0 +1,30 @@
+{
+ "version": 1,
+ "project": "pyspark",
+ "project_url": "https://spark.apache.org/";,
+ "repo": "../..",
+ "branches": ["master"],
+ "dvcs": "git",
+ "environment_type": "virtualenv",
+ "show_commit_url": "https://github.com/apache/spark/commit/";,
+ "benchmark_dir": ".",
+ "env_dir": ".asv/env",
+ "results_dir": ".asv/results",
+ "html_dir": ".asv/html",
+ "build_command": [
+ "python -m pip wheel --no-deps -w {build_cache_dir}
{conf_dir}/../packaging/classic"
+ ],
+ "install_command": [
+ "python -m pip install --find-links {build_cache_dir} pyspark"
+ ],
+ "uninstall_command": [
+ "python -m pip uninstall -y pyspark"
+ ],
+ "matrix": {
+ "req": {
+ "pyarrow": [""],
+ "pandas": [""],
+ "numpy": [""]
+ }
Review Comment:
shall we pin versions of libraries?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
