LuciferYang commented on code in PR #54280:
URL: https://github.com/apache/spark/pull/54280#discussion_r2797135644
##########
core/src/main/scala/org/apache/spark/deploy/history/EventLogFileWriters.scala:
##########
@@ -131,7 +131,20 @@ abstract class EventLogFileWriter(
}
protected def closeWriter(): Unit = {
+ // 1. Flush first to check the errors
+ writer.foreach(_.flush())
+ if (writer.exists(_.checkError())) {
+ logWarning("Spark detects errors while flushing event logs.")
+ }
+ hadoopDataStream.foreach(_.hflush())
+
+ // 2. Try to close and check the errors
writer.foreach(_.close())
Review Comment:
In the case of HDFS, it should presumably not throw an exception; instead, a
boolean status would be set to true. However, I'm not sure whether third-party
libraries will adhere to this convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
