heyihong commented on code in PR #54056:
URL: https://github.com/apache/spark/pull/54056#discussion_r2804015170


##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -5487,6 +5409,149 @@
     ],
     "sqlState" : "42601"
   },
+  "SPARK_CONNECT_ILLEGAL_STATE" : {
+    "message" : [
+      "Spark Connect encountered an illegal state condition."
+    ],
+    "subClass" : {

Review Comment:
   I think we should add some tests to at least make sure these errors can be 
constructed successfully (i.e., that the parameters are matched correctly). 
It’s nice that we’ve refactored the error construction to IllegalStateErrors, 
so the construction logic should be easier to test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to