cloud-fan commented on code in PR #54325:
URL: https://github.com/apache/spark/pull/54325#discussion_r2817231446
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/RowSetUtils.scala:
##########
@@ -142,7 +142,11 @@ object RowSetUtils {
val value = if (row.isNullAt(ordinal)) {
""
} else {
- toHiveString((row.get(ordinal), typ), nested = true,
timeFormatters, binaryFormatter)
+ val nested = typ match {
+ case _: GeometryType | _: GeographyType => false
Review Comment:
seems the parameter `nested` is abused here, as it's not to indicate
nesting, but to ask for a pretty string format. Does it mean we should use
`nested=false` for other types as well as this is not nesting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
