uros-db commented on code in PR #54325:
URL: https://github.com/apache/spark/pull/54325#discussion_r2817257968
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/RowSetUtils.scala:
##########
@@ -142,7 +142,11 @@ object RowSetUtils {
val value = if (row.isNullAt(ordinal)) {
""
} else {
- toHiveString((row.get(ordinal), typ), nested = true,
timeFormatters, binaryFormatter)
+ val nested = typ match {
+ case _: GeometryType | _: GeographyType => false
Review Comment:
Well actually I think it's more of a clarity issue rather than abuse,
because all of this is handled under the `case _` branch so it's assumed that
nested is handled here implicitly.
If we want to completely separate geo types from this default branch, we
could add a new special case before this one (although this would be 99%
copy-paste, so a lot of code duplication).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
