Github user kanzhang commented on the pull request:
https://github.com/apache/spark/pull/6676#issuecomment-110963513
> We're talking about a patch that would be a few lines long with my
suggestion
The line savings may not be that dramatic. We could save a few lines around
getting and setting `appSecret`. But we still need to filter out the secret key
from java options. The bulk of this patch is actually unit tests making sure
that does happen in all 3 places where we build executor commands, and code
refactoring those tests depend on (see my initial comment at the top).
In any case, I'd like to leave this open for a few days, to give others an
opportunity to comment on if they wish.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
