Github user kanzhang commented on the pull request:
https://github.com/apache/spark/pull/6676#issuecomment-110986007
> There's a single method in SparkConf that already does the filtering.
There's no need to add a bunch of other methods to do slightly different
filtering, like you're doing. .... The change to fix the bug is, literally, 3
lines of code. Maybe 4 if you need to handle Mesos too.
Are you referring to `isExecutorStartupConf`? I didn't want to change it
because it was also used in YARN. If you are sure there is no side-effect for
YARN, I can consolidate `isStandaloneExecutorStartupConf` with it. That saves
one method (2 lines). Anything else? We still need to do the actual filtering
in `Client`, `StandaloneRestServer` and `SparkDeploySchedulerBackend`, right?
That's 3 lines already. And we need the newly introduced
`isNotClusterAuthSecretConf` method for the first 2 cases, right?
Again, please comment on the code so I know exactly what you are talking
about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
