adith-os opened a new pull request, #55783:
URL: https://github.com/apache/spark/pull/55783

   
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
        
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the 
guideline first in
        'common/utils/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   
   
   This PR adds support for PyArrow-backed dtypes (e.g., bool[pyarrow]) in 
PySpark's pandas API. The changes include:
   - Type detection and conversion: Added is_pyarrow_backed_dtype() function to 
detect PyArrow-backed dtypes and enhanced as_spark_type() to convert them to 
appropriate Spark types.
   - Dtype preservation: Enhanced spark_type_to_pandas_dtype() with a 
use_arrow_dtypes parameter to preserve PyArrow dtypes when converting from 
Spark types back to pandas dtypes.
   - Propagation through operations: Updated comparison operators in 
data_type_ops/base.py to preserve PyArrow dtypes in results, and propagated the 
use_arrow_dtypes parameter through InternalField.from_struct_field() and 
related code paths.
   
   <!--
   Please clarify what changes you are proposing. The purpose of this section 
is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster 
reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class 
hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other 
DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   
   Starting with pandas 3.0, when PyArrow is installed, pandas automatically 
uses PyArrow-backed dtypes for string columns. Without this PR, PySpark's 
pandas API loses dtype information when working with PyArrow-backed dtypes
   
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Users working with PyArrow-backed dtypes will now see their dtypes 
preserved through PySpark operations
   Before the PR:
   ```
   >>> 26/05/09 19:25:26 WARN GarbageCollectionMetrics: To enable non-built-in 
garbage collector(s) List(scavenge), users should configure it(them) to 
spark.eventLog.gcMetrics.youngGenerationGarbageCollectors or 
spark.eventLog.gcMetrics.oldGenerationGarbageCollectors
   26/05/09 19:25:26 WARN GarbageCollectionMetrics: To enable non-built-in 
garbage collector(s) List(global, scavenge), users should configure it(them) to 
spark.eventLog.gcMetrics.youngGenerationGarbageCollectors or 
spark.eventLog.gcMetrics.oldGenerationGarbageCollectors
   import warnings
   >>> warnings.filterwarnings('ignore')
   >>> 
   >>> import pandas as pd
   >>> print(f"pandas: {pd.__version__}")
   pandas: 3.0.2
   >>> 
   >>> import pyspark.pandas as ps
   >>> s1 = ps.Series(['a', 'b', 'c'], dtype='string')
   >>> s2 = ps.Series(['a', 'x', 'c'], dtype='string')
   >>> result = s1 == s2
   >>> print(f"result dtype: {result.dtype}")
   result dtype: boolean
   >>> print(result)
   0     True                                                                   
   
   1    False
   2     True
   dtype: boolean
   >>> 
   ```
   After the PR:
   ```
   >>> 26/05/09 19:19:05 WARN GarbageCollectionMetrics: To enable non-built-in 
garbage collector(s) List(scavenge), users should configure it(them) to 
spark.eventLog.gcMetrics.youngGenerationGarbageCollectors or 
spark.eventLog.gcMetrics.oldGenerationGarbageCollectors
   26/05/09 19:19:05 WARN GarbageCollectionMetrics: To enable non-built-in 
garbage collector(s) List(global, scavenge), users should configure it(them) to 
spark.eventLog.gcMetrics.youngGenerationGarbageCollectors or 
spark.eventLog.gcMetrics.oldGenerationGarbageCollectors
   
   >>> import warnings
   >>> warnings.filterwarnings('ignore')
   >>> 
   >>> import pandas as pd
   >>> print(f"pandas: {pd.__version__}")
   pandas: 3.0.2
   >>> 
   >>> import pyspark.pandas as ps
   >>> s1 = ps.Series(['a', 'b', 'c'], dtype='string')
   s2 = ps.Series(['a', 'x', 'c'], dtype='string')
   result = s1 == s2
   print(f"result dtype: {result.dtype}")
   print(result)
   
   >>> s2 = ps.Series(['a', 'x', 'c'], dtype='string')
   >>> result = s1 == s2
   >>> print(f"result dtype: {result.dtype}")
   result dtype: bool[pyarrow]
   >>> print(result)
   0     True
   1    False
   2     True
   dtype: bool[pyarrow]
   >>> 
   ```
   <!--
   Note that it means *any* user-facing change including all aspects such as 
new features, bug fixes, or other behavior changes. Documentation-only updates 
are not considered user-facing changes.
   
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   
   New tests in python/pyspark/pandas/tests/test_typedef.py:
   - test_as_spark_type_pyarrow_dtypes() - Tests conversion to Spark types
   - test_spark_type_to_pandas_dtype_with_arrow_flag() - Tests conversion back 
to pandas dtypes
   - test_is_str_dtype_with_pyarrow() - Tests string dtype detection
   - test_is_pyarrow_backed_dtype() - Tests PyArrow dtype detection
   
   Integration test in 
python/pyspark/pandas/tests/data_type_ops/test_string_ops.py:
   - test_pyarrow_backed_string_comparisons() - Tests dtype preservation in 
comparison operations
   
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions 
for the consistent environment, and the instructions could accord to: 
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   <!--
   If generative AI tooling has been used in the process of authoring this 
patch, please include the
   phrase: 'Generated-by: ' followed by the name of the tool and its version.
   If no, write 'No'.
   Please refer to the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   Yes. Generated-by: GPT 5.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to