XdithyX opened a new pull request, #55782:
URL: https://github.com/apache/spark/pull/55782
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR replaces the legacy parser error class used by invalid `TABLESAMPLE`
fractions with a named error class
([SPARK-56638](https://issues.apache.org/jira/browse/SPARK-56638)).
Specifically, this PR:
- Adds `INVALID_TABLESAMPLE_FRACTION` to `error-conditions.json`
- Adds `QueryParsingErrors.invalidTableSampleFractionError`
- Replaces the generic `ParserUtils.validate(...)` call in
`AstBuilder.withSample(...)` for TABLESAMPLE fraction validation
- Updates `PlanParserSuite` to assert the new error class
The validation logic is unchanged. `TABLESAMPLE` fractions are still
required to be in the `[0, 1]` interval, allowing the existing rounding epsilon.
### Why are the changes needed?
`ParserUtils.validate(...)` always throws `_LEGACY_ERROR_TEMP_0064`, which
is a generic legacy error class.
For invalid `TABLESAMPLE` fractions, the parser already knows the specific
failure: the computed sampling fraction is outside the allowed `[0, 1]`
interval. Using a named error class makes the error condition explicit and
continues the ongoing cleanup of legacy temporary error classes.
This PR does not update `ParserUtils.validate(...)` itself because that
helper is shared by unrelated parser validations. Making it throw
`INVALID_TABLESAMPLE_FRACTION` would incorrectly label non-TABLESAMPLE parser
failures as TABLESAMPLE fraction errors.
The new error uses SQLSTATE `22023` because the statement is syntactically
valid, but the supplied numeric value is invalid/out of range. This is
consistent with existing Spark error conditions for invalid argument or range
values, such as `INVALID_NUMERIC_LITERAL_RANGE` and other `22023`
value-validation errors, rather than `42601`, which is used for syntax errors.
### Does this PR introduce _any_ user-facing change?
Yes, for invalid `TABLESAMPLE` fractions, the error class changes from
`_LEGACY_ERROR_TEMP_0064` to `INVALID_TABLESAMPLE_FRACTION`.
### How was this patch tested?
Ran build/sbt 'catalyst / Test / testOnly
org.apache.spark.sql.catalyst.parser.PlanParserSuite -- -z "sampled relations"'
### Was this patch authored or co-authored using generative AI tooling?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
