jerrypeng commented on PR #55620: URL: https://github.com/apache/spark/pull/55620#issuecomment-4464842895
> The PR description is now out of sync with the implementation. > > The PR body still says this patch adds the STREAMING_SHUFFLE_UNEXPECTED_MESSAGE_TYPE error class, adds a spark-common-utils Maven dependency, and makes StreamingShuffleMessage.decode() throw a SparkRuntimeException for unknown message types. The latest diff no longer does any of that: the dependency and error-condition changes were removed, and unknown message IDs now result in an IllegalArgumentException. > > This should be updated before merge so reviewers and future readers do not rely on stale protocol/error-handling documentation. It would also be clearer to replace “message-type ordinal” with “message-type id”, since the wire format uses the explicit id() values rather than enum ordinals. I have updated the PR description. Thank you for the reminder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
