jerrypeng commented on code in PR #55620: URL: https://github.com/apache/spark/pull/55620#discussion_r3263926831
########## common/network-common/src/main/java/org/apache/spark/network/shuffle/streaming/CreditControlMessage.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.network.shuffle.streaming; + +import io.netty.buffer.ByteBuf; +import io.netty.buffer.CompositeByteBuf; + +/** + * Sent from the client to the server to indicate that the client is ready to receive + * the specified amount of messages from the server. + */ +public final class CreditControlMessage extends StreamingShuffleMessage { + public int shuffleWriterId; + public int shuffleReaderId; + + public int numMessages; Review Comment: The current implementation does not implement a credit based backpressure mechanism so this message is really on used to ack messages received by the streaming shuffle reader. The field numMessage is set to equal the number of messages received and to inform the sender / shuffle writer of additional credits / buffers available now on the reader. To be honest, all of this is really easy to change. Since none of the wire protocol is persisted to durable storage and there is no scenario client and server will be on different versions. It is really easy for us to change in the future. I will add a comment on how it is currently used and what it is designed to do for future implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
