gengliangwang commented on PR #55940: URL: https://github.com/apache/spark/pull/55940#issuecomment-4484510573
Good point, thanks @cloud-fan. I followed the codebase convention: existing utility files like `ArrayExpressionUtils.java`, `BitmapExpressionUtils.java`, `ToJavaArrayUtils.java`, `ExpressionImplUtils.java`, etc. are **category-scoped** (not per-expression), so the per-expression naming I introduced here was inconsistent. Plan across the SPARK-56908 stack: | Util class | Scope | Status | |---|---|---| | `CastUtils.java` | All `Cast` ANSI helpers (PRs #55934-#55937, #55939) | Keep — already broad | | `ArithmeticUtils.java` | All `BinaryArithmetic` ANSI helpers (PR #55938) | Keep — already broad | | **`DateTimeExpressionUtils.java`** (was `MakeDateAndIntervalUtils`) | Shared by date/time/interval expression ANSI codegen (this PR) | **Renamed here in d1189617b5d** | | `ElementAtUtils.java` → fold into existing `ArrayExpressionUtils.java` (PR #55941) | TBD on #55941 | Follow-up | The new name parallels `ArrayExpressionUtils.java` and gives future date/time/interval ANSI helpers a natural home without rev-locking another file rename. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
