viirya commented on PR #55940: URL: https://github.com/apache/spark/pull/55940#issuecomment-4490401885
The PR description still references DateTimeConstructorUtils.java and describes makeDateExact as wrapping LocalDate.of(...) + DateTimeUtils.localDateToDays(...) in the ansiDateTimeArgumentOutOfRange try/catch — but the final class is DateTimeExpressionUtils.java, and per the javadoc tightening in c13127edf81, the helper only catches the DateTimeException from LocalDate.of(...) (the ArithmeticException from localDateToDays's internal toIntExact propagates). Could you refresh the PR body so the squash commit message picks up the accurate description? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
