aokolnychyi commented on code in PR #56044:
URL: https://github.com/apache/spark/pull/56044#discussion_r3283418164
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ChangelogContext.java:
##########
@@ -20,16 +20,18 @@
import java.util.Objects;
import org.apache.spark.annotation.Evolving;
+import org.apache.spark.sql.util.CaseInsensitiveStringMap;
/**
* Encapsulates the parameters of a Change Data Capture (CDC) query, passed
from the
* parser / DataFrame API to the catalog's
- * {@link TableCatalog#loadChangelog(Identifier, ChangelogInfo)} method.
+ * {@link TableCatalog#loadChangelog(Identifier, ChangelogContext,
CaseInsensitiveStringMap)}
+ * method.
*
* @since 4.2.0
*/
@Evolving
-public class ChangelogInfo {
Review Comment:
My proposal would be:
```
loadTable(ident, tableContext (timeTravelSpec, writePrivileges), options)
loadChangelog(ident, changelogContext (range, deduplicationMode, etc),
options)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
