gengliangwang commented on code in PR #56044:
URL: https://github.com/apache/spark/pull/56044#discussion_r3284547997
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -195,22 +196,24 @@ default Table loadTable(Identifier ident, long timestamp)
throws NoSuchTableExce
/**
* Load a {@link Changelog} for the given table, representing the row-level
changes within the
- * range specified by {@code changelogInfo}.
+ * range specified by {@code context}.
* <p>
* The default implementation throws an analysis exception indicating that
the catalog does
* not support CDC. Catalogs that support CDC must override this method.
*
* @param ident a table identifier
- * @param changelogInfo the CDC query parameters (range, deduplication mode,
etc.)
+ * @param context the CDC query context (range, deduplication mode, etc.)
+ * @param options all options passed to the changelog query
Review Comment:
Worth noting the overlap with `context`: CDC-recognized keys (range,
deduplication mode, etc.) appear in `options` as well as in the parsed
`context`. Connectors that validate against an allowlist of unknown keys may
otherwise be surprised.
```suggestion
* @param options all options passed to the changelog query, including the
CDC-recognized
* keys (range, deduplication mode, etc.) that are also
parsed into {@code context}
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/RelationChanges.scala:
##########
@@ -33,10 +33,10 @@ import org.apache.spark.sql.connector.catalog.ChangelogInfo
* [[UnresolvedLeafNode]]). Tree traversals like `transformUp` will not visit
`relation`.
*
* @param relation the table relation (typically an [[UnresolvedRelation]])
- * @param changelogInfo the CDC query parameters (range, deduplication mode,
etc.)
+ * @param changelogContext the CDC query parameters (range, deduplication
mode, etc.)
Review Comment:
Minor: the type is now `ChangelogContext`, so "context" matches better than
"parameters".
```suggestion
* @param changelogContext the CDC query context (range, deduplication mode,
etc.)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
