szehon-ho commented on code in PR #54126:
URL: https://github.com/apache/spark/pull/54126#discussion_r3327808962
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/connector/ColumnImpl.scala:
##########
@@ -27,6 +27,6 @@ case class ColumnImpl(
nullable: Boolean,
comment: String,
defaultValue: ColumnDefaultValue,
- generationExpression: String,
+ columnGenerationExpression: GenerationExpression,
Review Comment:
I kept this as `columnGenerationExpression`. The `Column` interface already
exposes `String generationExpression()` (retained for backward compatibility,
now delegating to the new getter's SQL form), and Java can't overload on return
type alone, so the new `GenerationExpression`-returning accessor needs a
distinct name. Open to a better name if you have a preference.
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/GenerationExpression.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.connector.catalog;
+
+import java.util.Map;
+import java.util.Objects;
+import javax.annotation.Nullable;
+
+import org.apache.spark.SparkIllegalArgumentException;
+import org.apache.spark.annotation.Evolving;
+import org.apache.spark.sql.connector.expressions.Expression;
+
+/**
+ * A class that represents generation expressions for computed/generated
columns.
+ * <p>
+ * Connectors can define generation expressions using either a SQL string
(Spark SQL dialect) or an
Review Comment:
Captured this in the class javadoc: the SQL-string form is for backward
compatibility and is parsed/analyzed lazily (so its meaning can depend on
session config like ANSI mode / time zone and may be ambiguous), whereas the
`Expression` form captures the semantics fully and unambiguously, similar to
how a view captures the configs it was created with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
