uros-db commented on code in PR #56266: URL: https://github.com/apache/spark/pull/56266#discussion_r3341028362
########## sql/api/src/main/scala/org/apache/spark/sql/types/ops/TimestampNanosTypeApiOps.scala: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.types.ops + +import org.apache.spark.SparkException +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.catalyst.encoders.AgnosticEncoder +import org.apache.spark.sql.errors.DataTypeErrorsBase +import org.apache.spark.sql.types.{TimestampLTZNanosType, TimestampNTZNanosType} + +/** + * Client-side (spark-api) operations shared by the nanosecond timestamp types + * (TimestampNTZNanosType and TimestampLTZNanosType). + * + * Internal values are [[org.apache.spark.unsafe.types.TimestampNanosVal]] (epoch micros + nanos + * within the micro). The two concrete subclasses differ only in their DataType and SQL-literal + * prefix; storage and formatting are identical. + * + * SCOPE (SPARK-57207): this issue wires physical representation, literals, row accessors, and + * codegen class selection. String formatting is not yet implemented: format() throws an internal + * error so callers get a clear message rather than a debug string; dedicated fractional-second + * formatters land in a follow-up issue. + * Dataset encoders are out of scope (SPARK-57033 and related), so getEncoder reports the type as + * unsupported, matching the legacy RowEncoder behavior. + * + * @since 4.3.0 + */ +abstract class TimestampNanosTypeApiOps extends TypeApiOps with DataTypeErrorsBase { + + /** SQL literal prefix for this type, e.g. "TIMESTAMP_NTZ" or "TIMESTAMP_LTZ". */ + protected def sqlTypeName: String + + // ==================== String Formatting ==================== + + // String formatting of nanosecond timestamps is not yet implemented (follow-up after + // SPARK-57207). Throw an internal error so that callers see a clear message rather than a + // debug toString from TimestampNanosVal. + override def format(v: Any): String = Review Comment: +1 with @stevomitric here too format feeds CAST-to-STRING via the framework dispatch. The legacy default has no nanos case and falls through to case _ => o => UTF8String.fromString(o.toString) (line 185 of ToStringBase.scala) — i.e. flag-off produces a (debug) string and does not throw. With the flag on, the PR's format throws SparkException.internalError. So enabling the framework changes a user-visible CAST from "returns a string" to "INTERNAL_ERROR". internalError is also developer-facing and inappropriate for a user-triggered cast. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
