MaxGekk commented on PR #56266: URL: https://github.com/apache/spark/pull/56266#issuecomment-4603619595
A general note for reviewers: the dual logic (framework + legacy) is only present for the `Time` data type, as it had been developed prior to the Types Framework. Every other new data type should go through the framework. Accordingly, this PR routes the nanosecond timestamp types (`TimestampNTZNanosType` / `TimestampLTZNanosType`) exclusively through `TypeOps` / `TypeApiOps`: the legacy duplicate paths have been removed, and the types are unsupported when `spark.sql.types.framework.enabled` is off (enforced by a `checkValue` on `spark.sql.timestampNanosTypes.enabled`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
