peter-toth commented on PR #56275: URL: https://github.com/apache/spark/pull/56275#issuecomment-4604364280
> `QueryPlanningTracker.recordRuleInvocation` is not thread-safe because of `HashMap`. Could you wrap it with `synchronized`? > > https://github.com/apache/spark/blob/62cbb3ac4e47a2392cbb7b42cac1045be1d50f9b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/QueryPlanningTracker.scala#L201-L211 Yeah, good catch! Actually I didn't want to deal with subqueries yet. Adjusted with https://github.com/apache/spark/pull/56275/commits/27602b59baf02e5c600122653df5c7901b0a5ac6 so currently no concurrency issue can occur. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
