dongjoon-hyun commented on code in PR #56275:
URL: https://github.com/apache/spark/pull/56275#discussion_r3359391641
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/QueryPlanningTrackerEndToEndSuite.scala:
##########
@@ -58,6 +58,29 @@ class QueryPlanningTrackerEndToEndSuite extends StreamTest {
StopStream)
}
+ test("SPARK-57212: Track preparation rules") {
+ val df = spark.range(1000).selectExpr("count(*)")
+ df.collect()
+ val ruleNames = df.queryExecution.tracker.rules.keySet
+ assert(ruleNames.contains(classOf[
+ org.apache.spark.sql.execution.exchange.EnsureRequirements].getName))
+ assert(ruleNames.contains(classOf[
+ org.apache.spark.sql.execution.CollapseCodegenStages].getName))
+ }
Review Comment:
Could you double-check if this test case is sufficient as a test coverage?
It seems that we need `withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key ->
"false") {` explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
