uros-b commented on code in PR #56354: URL: https://github.com/apache/spark/pull/56354#discussion_r3368943177
########## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuiteBase.scala: ########## Review Comment: Maybe just add a few pre-1970 test cases with a non-zero fractial part, to convincingly self-document the "floor toward the past" guarantee for negative epochMicros. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
