uros-b commented on code in PR #56354:
URL: https://github.com/apache/spark/pull/56354#discussion_r3368945257
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala:
##########
@@ -1838,6 +1860,9 @@ case class Cast(
}
"""
}
+ case TimestampType =>
+ (c, evPrim, evNull) =>
+ code"$evPrim =
org.apache.spark.unsafe.types.TimestampNanosVal.fromParts($c, (short) 0);"
Review Comment:
Do we need the full qualification here? None of the other codegen cases seem
to be using it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
