LuciferYang commented on PR #56430: URL: https://github.com/apache/spark/pull/56430#issuecomment-4677429363
> There are two kinds of code for which we have not yet found a way to use javac directly, so they are routed to Janino - decided up front, not as a fallback after a failed compile: codegen in REPL / Connect interactive sessions (javac cannot resolve REPL-generated classes), and generated code referencing a class nested in a Scala `package object` (`package` is a Java reserved word, so the reference cannot be spelled in Java source). A one-time INFO log records each routing so the choice is visible to operators. This work is primarily intended to explore technical feasibility. As I noted in the PR description, there are at least two other scenarios still relying on Janino as a fallback implementation. > There are two kinds of code for which we have not yet found a way to use javac directly, so they are routed to Janino - decided up front, not as a fallback after a failed compile: codegen in REPL / Connect interactive sessions (javac cannot resolve REPL-generated classes), and generated code referencing a class nested in a Scala package object (package is a Java reserved word, so the reference cannot be spelled in Java source). A one-time INFO log records each routing so the choice is visible to operators. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
