LuciferYang commented on code in PR #56430:
URL: https://github.com/apache/spark/pull/56430#discussion_r3400279489
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala:
##########
@@ -595,7 +602,12 @@ case class NewInstance(
propagateNull: Boolean,
dataType: DataType,
outerPointer: Option[() => AnyRef]) extends InvokeLike {
+ // JVM-form binary name (with `$` for inner classes); used where literal `$`
+ // is intentional (e.g., Scala companion access `Foo$.MODULE$`).
private val className = cls.getName
+ // Dotted Java-source FQN; required by the JDK compiler in `new X(...)`
+ // expressions and casts. Equal to `className` for top-level classes.
Review Comment:
Right, the comment was wrong, took your wording in 1e5d2e3e3d2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
