MaxGekk commented on code in PR #56407:
URL: https://github.com/apache/spark/pull/56407#discussion_r3399066895
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteSupport.scala:
##########
@@ -188,6 +189,12 @@ class ParquetWriteSupport extends
WriteSupport[InternalRow] with Logging {
}
}
+ private def timestampNanosToEpochNanos(value: TimestampNanosVal): Long = {
Review Comment:
An out-of-range value here fails as `ArithmeticException: long overflow`
inside a task failure — no column name and no hint about the representable
range. The existing `DATETIME_OVERFLOW` error condition (SQLSTATE 22008,
helpers in `QueryExecutionErrors`) fits: catch the overflow and rethrow with
the offending value, and the overflow test can then pin the error condition
instead of walking the cause chain. Non-blocking — also fine as a follow-up
alongside the vectorized-reader work. (This existed in round 1; my miss for not
flagging it then.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
