Github user freeman-lab commented on the pull request:
https://github.com/apache/spark/pull/5267#issuecomment-111632563
Thanks for the effort @yu-iskw I think this has come together nicely! The
new linkageMatrix and adjacencyList features are very nice. I left a few
comments almost all are documentation nits. One thing that would still be
useful to add is discussion in the top-level docstring about how much data will
be cached by this algorithm.
@jkbradley or @mengxr as it's a big PR, one of you might want to take a
pass, but it looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
