dongjoon-hyun commented on code in PR #56528:
URL: https://github.com/apache/spark/pull/56528#discussion_r3417002306
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala:
##########
@@ -40,10 +40,10 @@ private[hive] class SparkSQLSessionManager(hiveServer:
HiveServer2, sparkSession
override def init(hiveConf: HiveConf): Unit = {
setSuperField(this, "operationManager", sparkSqlOperationManager)
- // Propagate the legacy toggle into HiveConf so that
HiveSessionImpl.setVariable,
- // which runs during session open before the SparkSession is attached, can
read it.
- hiveConf.setBoolean(
-
StaticSQLConf.LEGACY_HIVE_THRIFT_SERVER_ALLOW_SETTING_SYSTEM_PROPERTIES.key,
+ // SPARK-57480: stash the toggle on a static field instead of writing it
into HiveConf.
Review Comment:
ditto. Remove `SPARK-57480: `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
