dongjoon-hyun commented on code in PR #56528:
URL: https://github.com/apache/spark/pull/56528#discussion_r3417001259
##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java:
##########
@@ -251,8 +265,9 @@ public static int setVariable(String varname, String
varvalue) throws Exception
} else if (varname.startsWith(SYSTEM_PREFIX)){
// Setting JVM system properties is allowed only when the legacy
configuration
// spark.sql.legacy.hive.thriftServer.allowSettingSystemProperties is
enabled.
- if (ss.getConf().getBoolean(
- "spark.sql.legacy.hive.thriftServer.allowSettingSystemProperties",
false)) {
+ // The toggle is read from a static field set once at server init time,
NOT from the
+ // per-session HiveConf, to prevent bypass via `set:hiveconf:`
(SPARK-57480).
Review Comment:
Ditto. Remove `(SPARK-57480)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
