uros-b commented on code in PR #56498:
URL: https://github.com/apache/spark/pull/56498#discussion_r3420884811
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4546,6 +4546,11 @@
"expects a non-NULL value."
]
},
+ "OCCURRENCE" : {
+ "message" : [
+ "expects a positive value for `occurrence`, but got <actual>."
Review Comment:
Error message restates the parameter name and hardcodes backticks. The
parent INVALID_PARAMETER_VALUE message already prepends The value of
parameter(s) `occurrence` in `instr` is invalid: using the
<parameter>/<functionName> params you pass. Restating for `occurrence` is
redundant with the convention used by every other subclass (they say e.g.
"expects a binary value..." with no parameter name). Suggestion to use instead:
"expects a positive integer, but got <actual>."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
