uros-b commented on code in PR #56498:
URL: https://github.com/apache/spark/pull/56498#discussion_r3420892858
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##########
@@ -685,6 +685,45 @@ public static UTF8String execBinaryTrim(
}
}
+ public static class StringInstr4 {
Review Comment:
Nit: `StringInstr4` is a poor class name. Naming the expression after its
arity (4) is unusual for the codebase and will read oddly in stack traces /
future maintenance. Something like `StringInstrWithOccurrence` (or folding the
logic so there's one expression) would be more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
