MaxGekk commented on code in PR #56557:
URL: https://github.com/apache/spark/pull/56557#discussion_r3429069343
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala:
##########
@@ -917,6 +918,130 @@ abstract class OrcQuerySuite extends OrcQueryTest with
SharedSparkSession {
}
}
+ // Builds a single-column ("ts") DataFrame from external java.time values,
letting the schema
+ // precision truncate the sub-microsecond digits: an NTZ column takes
java.time.LocalDateTime
+ // values, an LTZ column takes the same wall clocks as java.time.Instant at
UTC.
+ private def nanosTimestampDf(nanosType: DataType, wallClocks:
Seq[LocalDateTime]): DataFrame = {
Review Comment:
Good point, done in c15a492d3ea. I moved `nanosTimestampDf` into `OrcTest`
so both `OrcQuerySuite` and `HiveOrcSourceSuite` share the same helper and
removed the duplicated local methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
