uros-b commented on code in PR #56557:
URL: https://github.com/apache/spark/pull/56557#discussion_r3431531265
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala:
##########
@@ -291,6 +291,8 @@ object OrcUtils extends Logging {
case m: MapType =>
s"map<${getOrcSchemaString(m.keyType)},${getOrcSchemaString(m.valueType)}>"
case _: DayTimeIntervalType | _: TimestampNTZType | _: TimeType =>
LongType.catalogString
+ case _: TimestampLTZNanosType => "timestamp with local time zone"
Review Comment:
Note: checkTimestampCompatibility doesn’t know about nanos;
OrcUtils.requestedColumnIds still only guards micros TimestampType ↔
TimestampNTZType mismatches. A file with timestamp_ntz(9) metadata read against
a micros TimestampNTZType schema (or the reverse) won’t get a clear error. Do
you intend to tackle this in the current PR, or would you prefer to do it
separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
