shrirangmhalgi commented on PR #55858: URL: https://github.com/apache/spark/pull/55858#issuecomment-4747233321
LGTM. Verified that `CheckAnalysis.operatorAllowsNonDeterministicExpressions` correctly respects the trait, and `ReplaceData / WriteDelta` are only constructed via rewrite rules where operation is always set. The `== MERGE` gate is the right granularity. Nit: The PR description still says `"with allowNonDeterministicExpression = true"` (unconditional), but the code gates on `operation.command() == MERGE`. Worth updating before merge so the description matches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
