yadavay-amzn commented on PR #55858: URL: https://github.com/apache/spark/pull/55858#issuecomment-4792780066
@cloud-fan A quick summary of the other review points, all addressed in 961bfab0: - WriteDelta (the v2Commands.scala:464 thread): handled by the same centralized `canInjectGroupFilters` determinism gate, so both the ReplaceData and WriteDelta paths are covered by one fix. - Test home (the AnalysisErrorSuite thread): added the end-to-end MERGE tests in a row-level-operation suite (reproduce-then-verify with the runtime group filter enabled); left only the boolean-getter assertions in AnalysisErrorSuite. - Negative coverage: added UPDATE alongside DELETE (for both ReplaceData and WriteDelta). - Nit: dropped the parens on `operation.command`. - Updated the PR description so it matches the `command == MERGE` gating and describes the new group-filter determinism guard. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
