csviri commented on PR #707: URL: https://github.com/apache/spark-kubernetes-operator/pull/707#issuecomment-4750353498
> No, you were clear. > > > maybe I was not clear, those are needed/used in the chainsaw test, and needs to be in this format. Or do I miss something? > > Maybe, I wasn't clear enough. My perspective was the following. > > * This is supposed to introduce a new alternative path which we should not affect the existing functionality and **test coverage**. > * In other words, this PR is supposed to introduce an independent set of test coverage instead of touching the existing test code and test resource. > > So, if you need to change some existing test resource for any reasons like the following, it should be done before this PR independently. > > > A key is always a new file. Ahh I see, change the PR! thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
