csviri commented on code in PR #707: URL: https://github.com/apache/spark-kubernetes-operator/pull/707#discussion_r3426681225
########## tests/e2e/watched-namespaces/spark-operator-dynamic-config-1.yaml: ########## @@ -17,7 +17,8 @@ apiVersion: v1 data: - spark.kubernetes.operator.watchedNamespaces: default, spark-1 + spark-operator-dynamic.properties: | + spark.kubernetes.operator.watchedNamespaces=default, spark-1 Review Comment: yes, afaik there is not way to mount all ConfigMap data in K8S. A key is always a new file. ########## tests/e2e/watched-namespaces/spark-operator-dynamic-config-2.yaml: ########## @@ -17,7 +17,8 @@ apiVersion: v1 data: - spark.kubernetes.operator.watchedNamespaces: default + spark-operator-dynamic.properties: | + spark.kubernetes.operator.watchedNamespaces=default Review Comment: Same as above: yes, afaik there is not way to mount all ConfigMap data in K8S. A key is always a new file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
