uros-b commented on code in PR #56473:
URL: https://github.com/apache/spark/pull/56473#discussion_r3444956457
##########
python/docs/source/tutorial/sql/python_data_source.rst:
##########
@@ -238,7 +238,7 @@ This is a dummy streaming data reader that generates 2 rows
in every microbatch.
"""
return {"offset": 0}
- def latestOffset(self) -> dict:
+ def latestOffset(self, start: dict, limit: ReadLimit) -> dict:
Review Comment:
Minor note - please check: the introductory FakeStreamReader.latestOffset is
now annotated limit: ReadLimit, but no preceding tutorial code block imports
ReadLimit (the shared "putting it together" import block at lines 120-126 omits
it; only the later Admission-Control block at line 350 and the new AvailableNow
block at line 407 import it). A reader copy-running this introductory example
standalone hits NameError: name 'ReadLimit' is not defined. That example's body
never uses limit (it just increments self.current), so either import ReadLimit
in its preamble or leave the introductory signature parameterless / use a plain
annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
