brijrajk commented on code in PR #56473:
URL: https://github.com/apache/spark/pull/56473#discussion_r3445274150
##########
python/docs/source/tutorial/sql/python_data_source.rst:
##########
@@ -238,7 +238,7 @@ This is a dummy streaming data reader that generates 2 rows
in every microbatch.
"""
return {"offset": 0}
- def latestOffset(self) -> dict:
+ def latestOffset(self, start: dict, limit: ReadLimit) -> dict:
Review Comment:
Good catch, thanks! Dropped the `ReadLimit` type annotation from the
introductory `FakeStreamReader.latestOffset` — the body never uses `limit` and
`ReadLimit` isn't imported in that block. The signature is now `def
latestOffset(self, start: dict, limit) -> dict:`, keeping the correct arity
without introducing a `NameError`. The fully-typed form is already shown in the
Admission Control section where the import is present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
